Support Apple Clang and fix building on macOS Sonoma #14452
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nastys
commented
Aug 8, 2023
nastys
commented
- Fixes "old style cast" error when building using the macOS 14 SDK
- Uses Apple's Clang compiler by default
- The CI script can now be used as a local build script
Megamouse
added
OS: macOS
Build and CI
nevack
reviewed
Aug 9, 2023
| if [ ! -d "/tmp/Qt/$QT_VER" ]; then | ||
| mkdir -p "/tmp/Qt" | ||
| rm -rf qt-downloader |
There was a problem hiding this comment.
Why thou?
Maybe it would be better to check if dir exists and is git repo.
nevack
reviewed
Aug 9, 2023
| @@ -1,3 +1,7 @@ | |||
| #if defined(__clang__) | |||
| #pragma clang diagnostic ignored "-Wold-style-cast" | |||
There was a problem hiding this comment.
I think better to fix this by changing get<>Version methods to return static_cast<int>(osver.<>) instead of suppressing this warning.
nevack
reviewed
Aug 9, 2023
| @@ -4,6 +4,10 @@ | |||
| #include <windows.h> | |||
|
|
|||
| #elif defined(__APPLE__) | |||
| #if defined(__clang__) | |||
| #pragma clang diagnostic ignored "-Wold-style-cast" | |||
There was a problem hiding this comment.
I think You're Holding It Wrong.
https://clang.llvm.org/docs/UsersManual.html#controlling-diagnostics-via-pragmas
You need to push, then ignore and finally pop before #elif defined(HAVE_QTDBUS) line
|
@nastys hi there! is it possible to resurrect this PR? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.